improve performance of the main-table path check during feature decoding#557
Open
cportele wants to merge 1 commit into
Open
improve performance of the main-table path check during feature decoding#557cportele wants to merge 1 commit into
cportele wants to merge 1 commit into
Conversation
NestingTracker.isNotMain() is called for every value row while decoding and did a List<List<String>>.contains(path), i.e. a linear scan with element-wise list equality. Make the main-table paths a Set so the membership test is O(1), and build it as a Set at the source in FeatureDecoderSql (the only caller). The main table path repeats once per sub-query, so the Set also drops the many duplicates the List carried. Membership semantics are unchanged, so the decoded output is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestingTracker.isNotMain()is called for every value row while decoding and did aList<List<String>>.contains(path), i.e. a linear scan with element-wise list equality. Make the main-table paths a Set so the membership test is O(1), and build it as a Set at the source in FeatureDecoderSql (the only caller). The main table path repeats once per sub-query, so the Set also drops the many duplicates the List carried. Membership semantics are unchanged, so the decoded output is identical.