Skip to content

feat: composer + circuit builder test#93

Open
iammadab wants to merge 13 commits into
laudiacay:mainfrom
iammadab:feat/composer_circuit_builder_test
Open

feat: composer + circuit builder test#93
iammadab wants to merge 13 commits into
laudiacay:mainfrom
iammadab:feat/composer_circuit_builder_test

Conversation

@iammadab

@iammadab iammadab commented Jan 10, 2024

Copy link
Copy Markdown

@iammadab iammadab requested a review from laudiacay as a code owner January 10, 2024 12:38
@iammadab

Copy link
Copy Markdown
Author

5 ported tests failing:

For the following, the decompose_into_base4_accumulators function hits a deadlock

  • test_range_constraint
  • test_range_constraint_fail
  • test_range_constraint_fail_2

For the following, the check_circuit check fails

  • test_and_constraint
  • test_xor_constraint

Other notes:

  • we are not sure what the parameters for the StandardComposer::new function should be
    • currently StandardComposer::new(5, 0, vec![])
  • in the C++ file there is a test grumpkin_base_case which uses grumpkin::fr
    • but StandardComposer functions make use of ark_bn254::Fr
    • we made use of the ark_bn254::Fr instead (passes) but it is something to note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants