Styling changes for Gradio Workbook - #982
Closed
zakariassoul wants to merge 9 commits into
Closed
Conversation
Created with `yo code`: https://code.visualstudio.com/api/get-started/your-first-extension
Successfully loads the local editor as a VSCode webview
Now that our actual local-editor works, no need to use the sample webview-ui to test the extension
Get the aiconfig from the VSCode textdocument: * The extension sends an `update` request to the webview when the TextDocument changes. * The webview handles that by updating the state of the AIConfig, which will trigger a re-render.
Delete an older experiment of a vscode extension. Main difference about this is it uses webpack for the build step but that's most likely unnecessary for our case.
Update content security policy to allow external images to render
Plus publish script for test-pypi
zakariassoul
requested review from
Ankush-lastmile,
jonathanlastmileai,
rholinshead,
rossdanlm,
saqadri and
suyoglastmileai
as code owners
January 19, 2024 04:53
This was referenced Jan 19, 2024
Closed
rossdanlm
pushed a commit
that referenced
this pull request
Jan 19, 2024
TSIA, see his orignial diff stack in #982
rossdanlm
pushed a commit
that referenced
this pull request
Jan 19, 2024
TSIA, see his orignial diff stack in #982 I also ran this command after to update the frontend static files from the `editor/client` directory: ``` rm -rf node_modules && yarn && yarn build ```
Contributor
|
Merge conflicts resolved in #985 |
rholinshead
requested changes
Jan 19, 2024
rholinshead
left a comment
rholinshead
left a comment
Collaborator
There was a problem hiding this comment.
I think this is from a pretty old stack & shouldn't be merged as-is. Gradio styles are in GradioTheme.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styling changes for Gradio Workbook
Plus publish script for test-pypi
Stack created with Sapling. Best reviewed with ReviewStack.