Conversation
rossdanlm
requested review from
Ankush-lastmile,
jonathanlastmileai,
rholinshead,
saqadri and
suyoglastmileai
as code owners
January 30, 2024 05:45
This was referenced Jan 30, 2024
rholinshead
reviewed
Jan 30, 2024
rholinshead
requested changes
Jan 30, 2024
rholinshead
left a comment
rholinshead
left a comment
Collaborator
There was a problem hiding this comment.
minor things but will save us from needing another PR in the future for the share button
I realized that after I moved `readOnly` check on entire group in #1032, I need to be able to still have the Download button for read-only mode so user can still download the AIConfig. We just need to make sure to define this endpoint in the lastMile repo ## Test Plan Rebase onto #1045 Go to `aiconfig/python/src/aiconfig/editor/client` and run this command: ``` rm -rf node_modules && yarn && yarn build ``` Then go to `aiconfig` dir and run this command: ``` aiconfig_path=./cookbooks/Gradio/huggingface.aiconfig.json parsers_path=./cookbooks/Gradio/hf_model_parsers.py aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` readOnly is true <img width="1920" alt="Screenshot 2024-01-30 at 00 45 03" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/356cd898-e3f2-430c-8153-a464b78a254b"> readOnly is false <img width="1920" alt="Screenshot 2024-01-30 at 00 44 36" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/d14ec7ee-8a10-49f1-b9d8-d4a5a2153b99">
rholinshead
approved these changes
Jan 30, 2024
rossdanlm
added a commit
that referenced
this pull request
Jan 30, 2024
…e() call (#1078) [fix] Update model parsers to config runtime on AIConfigRuntime.create() call Pretty good bug fix. If we define a model + model parser in a config and create it using `create()` instead of `load()` then this fails --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1078). * __->__ #1078 * #1071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download Button [4/n]: Make this enabled for read-only mode
I realized that after I moved
readOnlycheck on entire group in #1032, I need to be able to still have the Download button for read-only mode so user can still download the AIConfig. We just need to make sure to define this endpoint in the lastMile repoTest Plan
Rebase onto #1045
Go to
aiconfig/python/src/aiconfig/editor/clientand run this command:Then go to
aiconfigdir and run this command:readOnly is true
readOnly is false