Conversation
rossdanlm
force-pushed
the
pr1044
branch
3 times, most recently
from
January 26, 2024 22:00
2659326 to
cc17dab
Compare
rossdanlm
marked this pull request as ready for review
January 26, 2024 22:09
rossdanlm
requested review from
Ankush-lastmile,
jonathanlastmileai,
rholinshead,
saqadri and
suyoglastmileai
as code owners
January 26, 2024 22:09
rossdanlm
force-pushed
the
pr1044
branch
3 times, most recently
from
January 26, 2024 22:28
25672b7 to
6614544
Compare
Created a separate component for the shareButton to manage the `isLoading` state and show that in the UI ## Test Plan Rebase on then do: #1045 Go to `aiconfig/python/src/aiconfig/editor/client` and run this command: ``` rm -rf node_modules && yarn && yarn build ``` Then go to `aiconfig` dir and run this command: ``` aiconfig_path =./cookbooks/Gradio/huggingface.aiconfig.json parsers_path=./cookbooks/Gradio/hf_model_parsers.py aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` No Error Testing https://github.com/lastmile-ai/aiconfig/assets/151060367/1e9f4b90-a9e9-4c60-a813-afa2a46a1b5a Error Testing https://github.com/lastmile-ai/aiconfig/assets/151060367/1abcce37-8ba4-4513-b826-ea0f9d7bb720
rholinshead
approved these changes
Jan 26, 2024
rossdanlm
added a commit
that referenced
this pull request
Jan 28, 2024
Share Button [8/n] Show modal on UI click Showing the modal after button returns a URL. I'm pretty annoyed, wasn't able to get it: 1. Show up right beside the Share button 2. Have it look beautiful in the modal 3. Have the copy button be displayed on the right side (I was able to use position absolute, but now the label does not work and it's also not aligned with the padding for the X close button) ## Test plan https://github.com/lastmile-ai/aiconfig/assets/151060367/9fba2b38-0602-4a92-b77a-2d8624d8fe34 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1049). * __->__ #1049 * #1044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share Button [7/n]: Display loading UI
Created a separate component for the shareButton to manage the
isLoadingstate and show that in the UITest Plan
Rebase on then do: #1045
Go to
aiconfig/python/src/aiconfig/editor/clientand run this command:Then go to
aiconfigdir and run this command:No Error Testing
863f52e7-2c4a-4d8c-b931-40151e4dfc64.mp4
Error Testing
3c4753b9-4f63-4856-a188-2874ef519f54.mp4
Stack created with Sapling. Best reviewed with ReviewStack.