Codex/maplelib review fixes #19
Merged
Annotations
11 warnings and 1 notice
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-dotnet@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Build:
MapleLib/WzLib/Util/WzBinaryReader.cs#L299
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Util/WzBinaryReader.cs#L209
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Util/WzBinaryReader.cs#L187
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Util/WzBinaryReader.cs#L151
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Util/WzBinaryReader.cs#L113
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/MSFile/Snow2CryptoTransform.cs#L205
The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.
|
|
Build:
MapleLib/WzLib/WzProperties/WzCanvasProperty.cs#L264
'WzCanvasProperty.GetLinkedWzImageProperty()' hides inherited member 'WzImageProperty.GetLinkedWzImageProperty()'. Use the new keyword if hiding was intended.
|
|
Build:
MapleLib/WzLib/Serializer/WzFileExporter.cs#L105
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Serializer/WzFileExporter.cs#L64
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Build:
MapleLib/WzLib/Serializer/WzFileExporter.cs#L26
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
|
background
wait
wait-all
cancel
Loading