Realign project priorities#187
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughAdds an optional ChangesOTLP HTTP/protobuf transport, clone() fix, and E2E validation
Sequence Diagram(s)sequenceDiagram
participant Test as run-otlp-tests.mjs
participant Log as Log (larvit/log)
participant Fetch as fetch (OTLP HTTP)
participant Collector as OTel Collector (Docker)
participant File as /data/otlp-received.json
Test->>Collector: docker run otel/opentelemetry-collector-contrib
Test->>Test: waitUntil(collector HTTP reachable)
loop For each protocol: http/json, http/protobuf
Test->>Log: new Log({ otlpProtocol, otlpHttpBaseURI })
Log->>Log: log.error(msg, attrs)
Log->>Fetch: POST /v1/logs (JSON or protobuf body)
Fetch->>Collector: HTTP request
Collector->>File: write newline-delimited JSON record
Test->>Test: waitUntil(File has ≥1 record for protocol)
Test->>File: readReceivedData()
Test->>Test: assertLog() + assertSpan()
end
Test->>Collector: docker rm (finally)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Release Notes
New Features
"http/json") or Protobuf ("http/protobuf") encoding for telemetry exports.clone()method to inherit OTLP configuration and trace info settings from parent instances.Documentation
Tests