Robust ratio-study breakdown binning + explicit bins option#366
Open
drussellmrichie wants to merge 1 commit into
Open
Robust ratio-study breakdown binning + explicit bins option#366drussellmrichie wants to merge 1 commit into
drussellmrichie wants to merge 1 commit into
Conversation
Extract bin-edge computation into a pure helper (_compute_breakdown_edges) and fix two issues it now handles: 1. Robustness: the inline builder used np.quantile (returns NaN if the column has any NaN) and kept an edge whenever it was "not in bins" (no monotonicity guarantee). A heavily-skewed column (many rows sharing a value) collapsed the quantile edges to duplicates, so pd.cut raised "bins must increase monotonically" and crashed the whole ratio study. Now uses np.nanquantile, keeps only strictly-increasing edges, and returns no bins for a degenerate (all-NaN/constant) column so the breakdown is skipped. 2. New "bins" breakdown option: explicit value edges with optional "bin_labels". quantiles give equal-count bins (degenerate on skewed columns) and slice_size formats labels as integers (unusable for 0-1 columns); explicit bins cover those cases. Adds unit tests for the helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution. I affirm that this contributor has signed the CLA Russell Richie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts breakdown bin-edge computation into a pure helper (
_compute_breakdown_edges) and fixes two issues:Robustness: the inline builder used
np.quantile(returns NaN if the column has any NaN) and kept an edge whenever it wasnot in bins(no monotonicity guarantee). A heavily-skewed column (many rows sharing a value) collapsed the quantile edges to duplicates, sopd.cutraised"bins must increase monotonically"and crashed the entire ratio study. Now usesnp.nanquantile, keeps only strictly-increasing edges, and returns no bins for a degenerate (all-NaN/constant) column so the breakdown is skipped instead of crashing.New
binsbreakdown option: explicit value edges with optionalbin_labels.quantilesgive equal-count bins (degenerate on heavily-skewed columns) andslice_sizeformats labels as integers (unusable for 0–1 columns); explicitbinscover those cases.Adds unit tests for the helper.