Fix clear_cache() malformed .cols/.rows paths#364
Open
drussellmrichie wants to merge 1 commit into
Open
Conversation
clear_cache built the column/row fragment paths as f"{path}.cols{ext}"
(missing the dot before the extension) for the existence check and
f"{path}..cols.{ext}" (double dot) for removal — so the existence check
never matched and the large .cols.parquet / .rows.parquet column-diff
caches were silently left on disk. Use the correct {path}.cols.{ext} /
{path}.rows.{ext} templates. Adds a regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution. I affirm that this contributor has signed the CLA Russell Richie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clear_cache()built the column/row fragment paths asf"{path}.cols{ext}"(missing the dot before the extension) for the existence check andf"{path}..cols.{ext}"(double dot) for removal — so the existence check never matched and the large.cols.parquet/.rows.parquetcolumn-diff caches were silently left on disk. This uses the correct{path}.cols.{ext}/{path}.rows.{ext}templates.Adds a regression test (
tests/test_clear_cache_paths.py) that creates the full cache artifact set and asserts a clean sweep.