Skip to content

Fix clear_cache() malformed .cols/.rows paths#364

Open
drussellmrichie wants to merge 1 commit into
larsiusprime:masterfrom
drussellmrichie:fix/clear-cache-paths
Open

Fix clear_cache() malformed .cols/.rows paths#364
drussellmrichie wants to merge 1 commit into
larsiusprime:masterfrom
drussellmrichie:fix/clear-cache-paths

Conversation

@drussellmrichie

Copy link
Copy Markdown
Contributor

clear_cache() built the column/row fragment paths as f"{path}.cols{ext}" (missing the dot before the extension) for the existence check and f"{path}..cols.{ext}" (double dot) for removal — so the existence check never matched and the large .cols.parquet / .rows.parquet column-diff caches were silently left on disk. This uses the correct {path}.cols.{ext} / {path}.rows.{ext} templates.

Adds a regression test (tests/test_clear_cache_paths.py) that creates the full cache artifact set and asserts a clean sweep.

clear_cache built the column/row fragment paths as f"{path}.cols{ext}"
(missing the dot before the extension) for the existence check and
f"{path}..cols.{ext}" (double dot) for removal — so the existence check
never matched and the large .cols.parquet / .rows.parquet column-diff
caches were silently left on disk. Use the correct {path}.cols.{ext} /
{path}.rows.{ext} templates. Adds a regression test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution.
Please sign our CLA at the following link:
Click here to sign the CLA.

No action is required from you in this PR thread. Once you have signed the CLA externally, a maintainer will verify your signature and record it here on your behalf by commenting:


I affirm that this contributor has signed the CLA


Russell Richie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant