Use localized Google Play release notes instead of always falling back to English#548
Use localized Google Play release notes instead of always falling back to English#548
Conversation
Agent-Logs-Url: https://github.com/larryaasen/upgrader/sessions/03fc1405-bf83-405a-82a0-4f036c868938 Co-authored-by: larryaasen <325973+larryaasen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/larryaasen/upgrader/sessions/03fc1405-bf83-405a-82a0-4f036c868938 Co-authored-by: larryaasen <325973+larryaasen@users.noreply.github.com>
|
This PR addresses issue #544. @joelrose2 @deandreamatias Would you mind reviewing this PR? |
There was a problem hiding this comment.
Pull request overview
This PR updates Google Play release-notes parsing to prefer localized “What’s New” content by extracting release notes from the last [itemprop="description"] element, avoiding reliance on the English-only heading, and adds a regression test + README clarification.
Changes:
- Update Play Store release-notes extraction to use the last
[itemprop="description"]block (classic + redesigned parsing paths). - Add a parser unit test covering a classic Play Store page with a localized “What’s New” heading (Russian).
- Clarify in README that
Upgrader(languageCode: ...)requests localized Play Store listing content (including release notes).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/play_store_search_api.dart | Adds shared helper for release-notes extraction from [itemprop="description"] and uses it in classic/redesigned parsing. |
| test/play_store_test.dart | Adds a focused regression test ensuring localized release notes are selected over the main description. |
| README.md | Documents languageCode behavior for requesting localized Play Store content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I haven't all context of this app, but make sense the Dart syntax of this changes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 92.73% 91.92% -0.82%
==========================================
Files 12 12
Lines 1308 1312 +4
==========================================
- Hits 1213 1206 -7
- Misses 95 106 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Google Play release notes were being selected via the English
What's Newheading, so localized store pages could still surface English content in the upgrade dialog even whenUpgrader(languageCode: ...)requested another language.Play Store release-notes parsing
[itemprop="description"]block when extracting release notes.What's Newlabel and aligns with both classic and redesigned Play Store markup, where the last description block contains the localized release notes when available.Regression coverage
Что нового).Docs
languageCodeis used to request localized Google Play listing content, including release notes.With this change, when the Play Store has localized release notes for the requested language, Upgrader will use that localized content in the dialog.