Skip to content

Use localized Google Play release notes instead of always falling back to English#548

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-upgrader-issue-language-notes
Open

Use localized Google Play release notes instead of always falling back to English#548
Copilot wants to merge 4 commits intomainfrom
copilot/fix-upgrader-issue-language-notes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

Google Play release notes were being selected via the English What's New heading, so localized store pages could still surface English content in the upgrade dialog even when Upgrader(languageCode: ...) requested another language.

  • Play Store release-notes parsing

    • Prefer the last Play Store [itemprop="description"] block when extracting release notes.
    • This avoids coupling release-note detection to the English-only What's New label and aligns with both classic and redesigned Play Store markup, where the last description block contains the localized release notes when available.
  • Regression coverage

    • Add a focused parser test for a classic Play Store page whose release-notes section uses a localized heading (Что нового).
    • Verify release notes come from the localized release-notes block rather than the main app description.
  • Docs

    • Clarify that languageCode is used to request localized Google Play listing content, including release notes.
final upgrader = Upgrader(
  languageCode: 'ru',
);

With this change, when the Play Store has localized release notes for the requested language, Upgrader will use that localized content in the dialog.

Copilot AI and others added 2 commits April 29, 2026 00:45
Copilot AI changed the title [WIP] Fix Google Play Store language-specific release notes not appearing Use localized Google Play release notes instead of always falling back to English Apr 29, 2026
Copilot AI requested a review from larryaasen April 29, 2026 00:47
Comment thread lib/src/play_store_search_api.dart Outdated
@larryaasen
Copy link
Copy Markdown
Owner

This PR addresses issue #544. @joelrose2 @deandreamatias Would you mind reviewing this PR?

@larryaasen larryaasen marked this pull request as ready for review April 29, 2026 00:58
Copilot AI review requested due to automatic review settings April 29, 2026 00:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Google Play release-notes parsing to prefer localized “What’s New” content by extracting release notes from the last [itemprop="description"] element, avoiding reliance on the English-only heading, and adds a regression test + README clarification.

Changes:

  • Update Play Store release-notes extraction to use the last [itemprop="description"] block (classic + redesigned parsing paths).
  • Add a parser unit test covering a classic Play Store page with a localized “What’s New” heading (Russian).
  • Clarify in README that Upgrader(languageCode: ...) requests localized Play Store listing content (including release notes).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/src/play_store_search_api.dart Adds shared helper for release-notes extraction from [itemprop="description"] and uses it in classic/redesigned parsing.
test/play_store_test.dart Adds a focused regression test ensuring localized release notes are selected over the main description.
README.md Documents languageCode behavior for requesting localized Play Store content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/src/play_store_search_api.dart Outdated
@deandreamatias
Copy link
Copy Markdown

This PR addresses issue #544. @joelrose2 @deandreamatias Would you mind reviewing this PR?

I haven't all context of this app, but make sense the Dart syntax of this changes

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.92%. Comparing base (c8b8f96) to head (06d1c44).

Files with missing lines Patch % Lines
lib/src/play_store_search_api.dart 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   92.73%   91.92%   -0.82%     
==========================================
  Files          12       12              
  Lines        1308     1312       +4     
==========================================
- Hits         1213     1206       -7     
- Misses         95      106      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Play Store language-specific Release Notes not appearing, always the English version

4 participants