feat: 添加 32 位 Linux 多架构编译版本#1065
Open
yahao333 wants to merge 1 commit into
Open
Conversation
|
yanghao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📝 WalkthroughWalkthroughThis PR adds Changes32-bit Linux Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/M
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README_zh.md`:
- Around line 11-22: The architecture table and download examples reference
outdated artifacts like "lark-cli-linux-386" and architectures
(386/arm/mips*/ppc64/s390x/riscv64) that do not match the current release naming
pattern and builds; update README_zh.md to list only the actual supported
targets (e.g., linux/amd64 and linux/arm64) and change the wget/chmod/run
examples to use the real release artifact pattern
"lark-cli-<version>-linux-<arch>" (or sync the docs to new pipelines if you
intend to support the other arches), ensuring the table headers and any example
binary names are replaced accordingly.
- Around line 39-41: Update README_zh.md to avoid asserting the repo was built
with the patched oapi-sdk-go; change the sentence that currently says "已使用修复后的
`oapi-sdk-go` SDK 编译" to a conditional statement that tells users to ensure they
have a version containing PR `#211` (or map specific versions to the PR), e.g.
instructing "请确保使用包含 PR `#211` 修复的 `oapi-sdk-go` 版本（检查 go.mod 中的
github.com/larksuite/oapi-sdk-go/v3 版本或任何 replace 指令）再编译 32 位版本" or explicitly
state that v3.5.4 includes the fix if you can verify it; reference the PR number
(`#211`) and the go.mod pinned module (github.com/larksuite/oapi-sdk-go/v3 v3.5.4)
in the updated text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0136a3a7-3988-41f8-96b4-1a4ea20db8e3
📒 Files selected for processing (11)
README_zh.mdassets/lark-cli-linux-386assets/lark-cli-linux-armassets/lark-cli-linux-arm64assets/lark-cli-linux-mipsassets/lark-cli-linux-mips64assets/lark-cli-linux-mips64leassets/lark-cli-linux-mipsleassets/lark-cli-linux-ppc64assets/lark-cli-linux-riscv64assets/lark-cli-linux-s390x
Comment on lines
+11
to
+22
| | 二进制文件 | 架构 | 类型 | | ||
| |-----------|------|------| | ||
| | lark-cli-linux-386 | i386 | 32-bit x86 | | ||
| | lark-cli-linux-arm | ARM | 32-bit ARM | | ||
| | lark-cli-linux-arm64 | ARM64 | 64-bit ARM | | ||
| | lark-cli-linux-mips | MIPS | 32-bit 大端 | | ||
| | lark-cli-linux-mipsle | MIPS | 32-bit 小端 | | ||
| | lark-cli-linux-mips64 | MIPS64 | 64-bit 大端 | | ||
| | lark-cli-linux-mips64le | MIPS64 | 64-bit 小端 | | ||
| | lark-cli-linux-ppc64 | PowerPC | 64-bit | | ||
| | lark-cli-linux-s390x | IBM S/390 | 64-bit | | ||
| | lark-cli-linux-riscv64 | RISC-V | 64-bit | |
There was a problem hiding this comment.
文档中的架构列表与下载示例和当前构建配置不一致。
这里列出的 386/arm/mips*/ppc64/s390x/riscv64 以及示例二进制名 lark-cli-linux-386，与当前发布模板和构建脚本不匹配（现有上下文仅显示 linux/amd64、linux/arm64，且产物命名为 lark-cli-<version>-linux-<arch>）。这会直接导致用户按文档下载失败。建议将“支持架构表”和 wget/chmod/运行 示例改成与实际 Release 产物一致，或先同步提交对应构建流水线变更。
Also applies to: 28-35
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README_zh.md` around lines 11 - 22, The architecture table and download
examples reference outdated artifacts like "lark-cli-linux-386" and
architectures (386/arm/mips*/ppc64/s390x/riscv64) that do not match the current
release naming pattern and builds; update README_zh.md to list only the actual
supported targets (e.g., linux/amd64 and linux/arm64) and change the
wget/chmod/run examples to use the real release artifact pattern
"lark-cli-<version>-linux-<arch>" (or sync the docs to new pipelines if you
intend to support the other arches), ensuring the table headers and any example
binary names are replaced accordingly.
Comment on lines
+39
to
+41
| 这些版本使用修复后的 `oapi-sdk-go` SDK 编译，以支持 32 位系统。 | ||
|
|
||
| SDK 修复 PR: https://github.com/larksuite/oapi-sdk-go/pull/211 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# 验证仓库内是否已落地 SDK 修复（只读）
set -e
echo "== go.mod dependency =="
rg -n 'github.com/larksuite/oapi-sdk-go/v3|^replace ' go.mod
echo
echo "== go.sum entries =="
rg -n 'github.com/larksuite/oapi-sdk-go/v3' go.sum || true
echo
echo "== any local replace or patched reference =="
rg -n 'oapi-sdk-go|replace|pull/211|patched|修复' --glob '!**/vendor/**'Repository: larksuite/cli
Length of output: 50372
🏁 Script executed:
#!/bin/bash
set -e
echo "== README_zh.md: lines 35-45 =="
nl -ba README_zh.md | sed -n '35,45p'
echo
echo "== go.mod: oapi-sdk-go entries (and any replace) =="
rg -n 'oapi-sdk-go|replace ' go.mod || true
echo
echo "== go.sum: oapi-sdk-go/v3 entries (limit) =="
rg -n 'github.com/larksuite/oapi-sdk-go/v3' go.sum || true | head -n 20
echo
echo "== any reference to pull/211 or PR number 211 related to oapi-sdk-go =="
rg -n 'oapi-sdk-go|pull/211|PR[ -]?211|211' --glob '!**/vendor/**' --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/build/**' || trueRepository: larksuite/cli
Length of output: 50428
🏁 Script executed:
#!/bin/bash
set -e
echo "== README_zh.md: lines 35-45 (with numbers) =="
awk 'NR>=35 && NR<=45 {printf "%d:%s\n", NR, $0}' README_zh.md
echo
echo "== README_zh.md: mentions of oapi-sdk-go / pull/211 =="
rg -n 'oapi-sdk-go|pull/211|SDK 修复 PR' README_zh.md || true
echo
echo "== go.mod: exact oapi-sdk-go lines and any replace blocks =="
rg -n 'oapi-sdk-go|^replace ' go.mod || true
echo
echo "== go.mod: context around first match =="
first=$(rg -n 'oapi-sdk-go' go.mod | head -n1 | cut -d: -f1)
if [ -n "$first" ]; then
start=$((first-5)); [ $start -lt 1 ] && start=1
end=$((first+5))
sed -n "${start},${end}p" go.mod
fi
echo
echo "== any oapi-sdk-go/pull/211 reference in repo (narrow) =="
rg -n 'oapi-sdk-go/pull/211|pull/211' --glob '!**/vendor/**' --glob '!**/node_modules/**' || true
echo
echo "== go.mod files in repo (to ensure we checked the right one) =="
find . -maxdepth 4 -name go.mod -printRepository: larksuite/cli
Length of output: 1195
README_zh.md：把“已使用修复后 SDK 编译”改为条件性表述或补充版本到 PR 的映射
- README_zh.md 39-41 表示已使用修复后的
oapi-sdk-go（链接到 PR#211），但当前go.mod仅固定为github.com/larksuite/oapi-sdk-go/v3 v3.5.4，且未看到任何replace/本地补丁能证明确实落地了 PR#211的修复。 - 建议将文案改为“需先确保包含 PR
#211修复的oapi-sdk-go版本（以当前go.mod为准）后再编译 32 位版本”，或在文档中补充“v3.5.4 对应 PR#211已合并修复”的明确说明。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README_zh.md` around lines 39 - 41, Update README_zh.md to avoid asserting
the repo was built with the patched oapi-sdk-go; change the sentence that
currently says "已使用修复后的 `oapi-sdk-go` SDK 编译" to a conditional statement that
tells users to ensure they have a version containing PR `#211` (or map specific
versions to the PR), e.g. instructing "请确保使用包含 PR `#211` 修复的 `oapi-sdk-go` 版本（检查
go.mod 中的 github.com/larksuite/oapi-sdk-go/v3 版本或任何 replace 指令）再编译 32 位版本" or
explicitly state that v3.5.4 includes the fix if you can verify it; reference
the PR number (`#211`) and the go.mod pinned module
(github.com/larksuite/oapi-sdk-go/v3 v3.5.4) in the updated text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加 lark-cli 的 32 位及多架构 Linux 编译版本，支持：
二进制文件放在
assets/目录，可在 Release 中下载。注意：需要合并 SDK 修复后才能编译：larksuite/oapi-sdk-go#211
Summary by CodeRabbit