Fix asset upload failures with guzzlehttp/guzzle 7.15+ - #282
Merged
Conversation
Throwing from within a Pool 'rejected' callback leaves Guzzle's EachPromise in an inconsistent state, which Guzzle 7.15's scoped cURL multi handler waits no longer tolerate — wait() falls back to rejecting with 'Invoking the wait callback did not resolve the promise'. Capture the first failure in the callback instead, let the pool settle cleanly, and throw the RequestFailedException after wait() returns. Also close store request file streams in a finally block, open each stream only once (the lazy map previously ran fopen twice per file), and add a client() factory seam so the failure paths can be tested against a mock handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwing from within a Pool 'rejected' callback leaves Guzzle's EachPromise in an inconsistent state, which Guzzle 7.15's scoped cURL multi handler waits no longer tolerate — wait() falls back to rejecting with 'Invoking the wait callback did not resolve the promise'.
Capture the first failure in the callback instead, let the pool settle cleanly, and throw the RequestFailedException after wait() returns. Also close store request file streams in a finally block, open each stream only once (the lazy map previously ran fopen twice per file), and add a client() factory seam so the failure paths can be tested against a mock handler.