[13.x] Improve types of InteractsWithData when* helpers#60536
Open
dfinchenko wants to merge 1 commit into
Open
[13.x] Improve types of InteractsWithData when* helpers#60536dfinchenko wants to merge 1 commit into
dfinchenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InteractsWithData::whenEnum()method already carries full generic type information for its callback/default and return type, so static analysis can infer the precise result of awhenEnum(...)call. Its sibling conditional helpers in the same trait -whenHas(),whenFilled()andwhenMissing()- share the identical shape (run$callback($value)when the condition holds, otherwise run$default()or return$this) but are still typed@return $this|mixed, so a call collapses tomixed.This PR brings those three helpers in line by giving them the same generics:
The callback receives the resolved value (
data_get($this->all(), $key)), which ismixed, hencecallable(mixed): TReturn.assertTypecoverage for all three helpers is added undertypes/. No behavior changes.