[13.x] Add Batch::failureCallbacks for callback inspection#60534
Open
miladev95 wants to merge 1 commit into
Open
[13.x] Add Batch::failureCallbacks for callback inspection#60534miladev95 wants to merge 1 commit into
Batch::failureCallbacks for callback inspection#60534miladev95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch now exposes
failureCallbacks()so stored batches can be inspected in the same way asPendingBatch.PendingBatchalready hasfailureCallbacks(), butIlluminate\Bus\Batchonly exposed the boolean callback checks.This change fills that gap and keeps the pending and persisted batch APIs aligned.
The new method returns the registered failure callbacks from the batch options, or an empty array when none are present. I also added coverage in the Bus batch state tests for both
hasFailureCallbacks()andfailureCallbacks().