[13.x] Add nightly workflow to verify framework install#60532
Open
jackbayliss wants to merge 1 commit into
Open
[13.x] Add nightly workflow to verify framework install#60532jackbayliss wants to merge 1 commit into
jackbayliss wants to merge 1 commit into
Conversation
just one php ver is fine and reaname comment why match time as database nightly Revert "prove it breaks" This reverts commit 980dd3c. prove it breaks wip wip test
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
|
Love this but wonder if we might want this on any commit to a release branch/master rather than nightly. That way when a PR is merged or a commit is added right before a release it would still be caught |
Contributor
Author
|
@axlon Thanks man, yeah that's a good option, depends on what Taylor thinks I guess! I didn't want it to be too intrusive and annoying basically 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there's no tests for ensuring the latest branch installs correctly which #60525 highlighted
This PR adds a nightly workflow that:
Passing: https://github.com/jackbayliss/framework/actions/runs/27650345931
Catching a real breakage: https://github.com/jackbayliss/framework/actions/runs/27650957089/job/81774575916#step:5:492
This essentially is an attempt at catching any issues that affect installation / updating before it reaches the public
Should be fairly easy to maintain like all the other workflows.
Thought I'd give this a go to be visible to all, would rather more eyes, but I can run it myself so no drama if you don't dig it
Note: this currently relies on checking the workflow results, like the other nightly workflows, but you can wire them up to notifications etc if you want. Idea is for now, at least it's visible!