added gsub for to convert '?' strands to '*'#17
Open
areyesq89 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks @areyesq89 I decided to use "?"s as the new compilations (srav3h, srav1m, tcgav2, and gtexv2) have non-canonical splicing in them, where the strand is ambiguous. This was not true with the previous, recount2-related compilations (srav2, tcga, gtex, etc...) where the strand was always set. However, I didn't take converting to GRanges objects into consideration when I made that decision. So your update is a nice way to handle that for the time being. But I'll have a chat internally with the team and see long term what the best way to deal with this is before we do anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for putting together snapcount: it makes our jobs easier to many :)
I noticed that in the most recent versions of the database, sometimes the junction's strands are reported as "?". This caused errors when converting these junctions to a GRanges objects (and subsequently, SummarizedExperiments objects.
I added a
gsubto convert '?' strands to "*" before converting to GRanges objects.Hope this is useful,
Alejandro