fix: add bounds check before memcpy in decoder.cpp#449
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
|
@orbisai0security is attempting to deploy a commit to the langhuihui's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
wasm/decoder.cpp.Vulnerability
V-001wasm/decoder.cpp:267Description: The decoder performs three memcpy operations copying Y, U, and V plane data from decoded video frames into a destination buffer without validating that the copy sizes (videoWidth, halfw) fit within the allocated destination buffer. A malicious video stream with manipulated frame dimensions can cause writes beyond the allocated heap buffer in WebAssembly linear memory.
Evidence
Exploitation scenario: Attacker crafts a malicious H.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
wasm/decoder.cppVerification
Automated security fix by OrbisAI Security