Skip to content

fix: blank LangSmith input should disable tracing #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brace Sproul (bracesproul) merged 2 commits into from
Jul 5, 2026
Merged

fix: blank LangSmith input should disable tracing #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6971ef6
fix: make blank LangSmith input disable tracing
blue-az Jul 3, 2026
3db4d87
Merge branch 'main' into fix-blank-tracing
bracesproul Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/credentials.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,11 @@ export function InitSetup({
if (nextLangSmithKey.length > 0) {
updates.LANGCHAIN_PROJECT = "openwiki";
updates.LANGCHAIN_TRACING_V2 = "true";
} else {
// Blank input must act as an off switch: without this, a
// LANGCHAIN_TRACING_V2=true saved by an earlier setup stays in
// ~/.openwiki/.env and tracing silently remains enabled.
updates.LANGCHAIN_TRACING_V2 = "false";
}
}

Expand Down
Loading