fix: add Gemini API key to credential redaction and add missing unicode regex flags#378
Merged
Colin Francis (colifran) merged 1 commit intoJul 17, 2026
Conversation
Colin Francis (colifran)
approved these changes
Jul 17, 2026
Colin Francis (colifran)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Semianchuk Vitalii (@fix2015)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GEMINI_API_KEYto credential redaction insanitizeDiagnosticText(src/diagnostics.ts). The constantGEMINI_API_KEY_ENV_KEYalready existed inconstants.tsbut was missing from the redaction list, meaning Gemini API keys could leak into diagnostic output.src/agent/openai-chatgpt-oauth.ts). The sentence "OpenWiki login complete you can close this tab." was a run-on; added a period and capitalized accordingly.u) flag to regex patterns insrc/telemetry/gates.tsandsrc/telemetry/senders.tsfor consistency with the rest of the codebase and correct handling of unicode input.Test plan
sanitizeDiagnosticTextredactsGEMINI_API_KEYvalues from diagnostic output