spec-sync: track V2 spec drift - #138
Merged
Merged
Conversation
yzld2002
temporarily deployed
to
spec-sync-contract
August 3, 2026 08:06 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the V2 OpenAPI snapshot and regenerated reference models to track current service behavior.
Changes:
- Adds delivered-result metadata to parse and extract job responses.
- Clarifies estimated progress semantics.
- Regenerates models, removing stale build-schema operation models and updating generated references.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
specs/v2-aide.json |
Updates job metadata and progress contracts. |
specs/_generated/v2_models.py |
Regenerates models from the updated specification. |
yzld2002
temporarily deployed
to
spec-sync-contract
August 3, 2026 08:11 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (1)
specs/_generated/v2_models.py:549
- The regeneration removes all
V2ExtractBuildSchema*endpoint models (and the snapshot no longer contains/v2/extract/build-schema*paths), but the PR description characterizes this as metadata/progress-only drift and explicitly says there are no endpoint or route changes. That omission hides a material spec-surface deletion from reviewers. Please update the PR summary to call out the removed spec routes, or restore them if their removal was unintended.
class V2ExtractJobsGetParametersQuery(BaseModel):
tian-lan-landing
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated V2 spec-sync PR (
client.v2).Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.
What changed
AI-generated from the PR diff — verify against the actual changes.
Job(types/v2/job.py)Job.metadata: Optional[Dict[str, object]]— the result's metadata receipt (billing included), populated only for jobs completed viaoutput_save_url(result delivered tooutput_urlinstead of inline).Nonefor inline jobs, where metadata remains onresult.metadata.normalize_parse_job,normalize_extract_job) now extracts top-levelmetadatafrom the raw job envelope intoJob.metadata.Spec/doc notes (non-breaking, descriptive only)
parse_jobs/extract_jobspoll responses gain an optional top-levelmetadatafield (mirrors the above), documented inspecs/v2-aide.json.progressfield description clarified as an estimate (not a precise measurement); no schema/type change.No endpoint, route, or method signature changes.