refactor: remove index segment builder#6997
Open
Xuanwo wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated
IndexSegmentBuilderAPI and route staged index publishing through the existingcreate_index_uncommitted,merge_existing_index_segments, andcommit_existing_index_segmentsworkflow.IndexSegmentBuilderwas kept in the codebase after distributed vector indexing moved to the flatter merge-and-commit workflow. That leftover API created two competing ways to describe the same lifecycle, which made the codebase and bindings harder to reason about and caused confusion around whether callers should plan/build segments or just merge and commit existing segment metadata.This PR removes the parallel plan/build surface from Rust, Python, and Java bindings while keeping direct uncommitted segment commit support. FTS staged segments now finalize during commit metadata construction, so single-source staged FTS outputs no longer need a separate builder step before publishing.