Skip to content

refactor: remove index segment builder#6997

Open
Xuanwo wants to merge 2 commits into
mainfrom
xuanwo/remove-index-segment-builder
Open

refactor: remove index segment builder#6997
Xuanwo wants to merge 2 commits into
mainfrom
xuanwo/remove-index-segment-builder

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented May 29, 2026

Remove the deprecated IndexSegmentBuilder API and route staged index publishing through the existing create_index_uncommitted, merge_existing_index_segments, and commit_existing_index_segments workflow.

IndexSegmentBuilder was kept in the codebase after distributed vector indexing moved to the flatter merge-and-commit workflow. That leftover API created two competing ways to describe the same lifecycle, which made the codebase and bindings harder to reason about and caused confusion around whether callers should plan/build segments or just merge and commit existing segment metadata.

This PR removes the parallel plan/build surface from Rust, Python, and Java bindings while keeping direct uncommitted segment commit support. FTS staged segments now finalize during commit metadata construction, so single-source staged FTS outputs no longer need a separate builder step before publishing.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/index.rs 93.75% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo marked this pull request as ready for review May 29, 2026 14:16
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant