fix: schema-aware Arrow struct accessor for partial nested projections#531
Open
wombatu-kun wants to merge 1 commit into
Open
Conversation
4321029 to
cac7b86
Compare
cac7b86 to
45e6e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499 — partial projection of nested struct children (e.g.
SELECT s.b, s.c FROM toverstruct<a, b, c, d>) crashed the Lance vectorized reader withUnsupportedOperationExceptionfromArrowVectorAccessor.getLong.StructVectoralways carries all on-disk children in physical order;LanceStructAccessorwas binding by physical Arrow ordinal but Spark's generated projection (and external consumers like Hudi'sLanceRecordIterator) index by the pruned schema's ordinal — type mismatch.LanceArrowColumnVector(ValueVector, DataType)andLanceStructAccessor(StructVector, StructType)that bind Arrow children to a SparkStructTypeby name, recursing into nested structs.LanceFragmentColumnarBatchScanner.loadNextBatchthreads the input-partition schema through so lance-spark's own scan also uses the schema-aware path.ReadSchemaNestedStructWideningfrom fix: widen pruned nested struct schemas to preserve Arrow child ordinals #442 as defense-in-depth for the standard scan path.