fix(catalog): propagate namespace storage options into read options#522
Open
summaryzb wants to merge 1 commit into
Open
fix(catalog): propagate namespace storage options into read options#522summaryzb wants to merge 1 commit into
summaryzb wants to merge 1 commit into
Conversation
describeTable/declareTable responses can carry per-table storage options (vended credentials, region overrides) that must reach the read path. Pass them through createReadOptions at all five namespace-based call sites (createTable, stageCreate, stageCreateOrReplace, resolveIdentifier, and the time-travel rebuild in loadTableInternal). Also rename the six-arg createReadOptions overload to createPathBasedReadOptions so namespace code paths can no longer accidentally drop storage options, switch the seven-arg overload's storageOptions param to Optional<Map<String,String>> for consistency with the other optional params, and document the order dependency between storageOptions and withCatalogDefaults inline. Change-Id: Ib252c8948cf65bab848e1257a8536fffac7db1a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
describeTable/declareTable responses can carry per-table storage options (vended credentials, region overrides) that must reach the read path. Pass them through createReadOptions at all five namespace-based call sites (createTable, stageCreate, stageCreateOrReplace, resolveIdentifier, and the time-travel rebuild in loadTableInternal).
previously, if we get vended credentials via rest namespace, load table will fail, since storage options is not set to readOptions