chore: remove IDE artifacts from version control#22
Closed
wombatu-kun wants to merge 2 commits into
Closed
Conversation
The repository had 9 `.idea/` files committed against intent, totaling ~7.5 MB — dominated by `.idea/CopilotChatHistory.xml` (7.4 MB of AI chat history). The previous `.gitignore` enumerated `.idea/X.xml` entries piecemeal, which let other IDE files (encodings.xml, misc.xml, vcs.xml, codeStyles/, etc.) slip in. This commit: - Replaces the piecemeal `.idea/X.xml` block with a blanket `.idea` ignore plus symmetric `out/` handling, mirroring the sister repo `lance-format/lance-spark`. - Runs `git rm --cached` on all 9 tracked `.idea/` files. They remain on disk for local IntelliJ use but are no longer under version control. IDE-level codestyle (`.idea/codeStyles/*.xml`) is removed intentionally: the planned Spotless + google-java-format adoption will be the single source of truth for formatting; a separate IDE codestyle in git would diverge over time.
The shade plugin writes dependency-reduced-pom.xml next to pom.xml on every package build. Add it to .gitignore so it stops showing up as untracked after `mvn package`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wombatu-kun
force-pushed
the
chore/cleanup-ide-artifacts
branch
from
f128f1d to
471bb45
Compare
fightBoxing
pushed a commit
to fightBoxing/lance-flink
that referenced
this pull request
May 30, 2026
Port two additions from lance-format#22 (credit @wombatu-kun): - out/ (IntelliJ/Eclipse output dir) with the same src/main and src/test symmetric exclusions used for target/ and build/ - dependency-reduced-pom.xml (Maven shade plugin artifact) These complement the existing IDE + test-data runtime cleanup so the working tree stays clean across both IntelliJ and Eclipse users.
Collaborator
|
Hi @wombatu-kun, thanks for putting this together — you correctly identified a real pain point, and the I just opened #40 which covers the same cleanup with a slightly broader scope: Same as your PR:
Additionally in #40:
Two files your PR removes that #40 deliberately leaves for now:
Going to close this in favor of #40 to avoid duplicate review effort. Really appreciate the cleanup work — would love your eyes on #23 / #24 progress when you're back. 🙏 |
Collaborator
|
Closing in favor of #40 (which is a superset and now also includes the out/ + dependency-reduced-pom.xml ignores ported from this PR). See above comment for the full diff comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.idea/*.xmlignores with a blanket.ideaignore in.gitignore.out/handling (with the usualsrc/main/src/testexclusions), consistent with the existingtarget/andbuild/blocks in this file.git rm --cachedall 9 previously-tracked.idea/files — they stay on contributors' disks for local IntelliJ use but are no longer under version control.The tracked files removed from the index:
.idea/CopilotChatHistory.xml.idea/CopilotChatTabs.xml.idea/MarsCodeWorkspaceAppSettings.xml.idea/codeStyles/Project.xml,.idea/codeStyles/codeStyleConfig.xml.idea/encodings.xml,.idea/misc.xml,.idea/vcs.xml.idea/.gitignore.ideais blanket-ignored