Fix crash in error event listener#2
Open
supermario wants to merge 1 commit into
Open
Conversation
WebSocket error events are not CloseEvents and don't have .code/.reason properties. Accessing undefined values crashed decodeCloseEventCode in the Elm runtime. Use 1006 (AbnormalClosure) as the fallback, which is the correct semantic code for connection errors. Also adds Kernel JS tests and GitHub CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorevents are notCloseEventobjects — they don't have.codeor.reasonproperties_LamderaWebsocket_listenpassedevent.code(undefined) toclosedEvent, which crasheddecodeCloseEventCodein the Elm runtimeevent.code || 1006andevent.reason || ""as fallbacks — 1006 (AbnormalClosure) is the correct semantic code for connection errorsTest plan
node --test test/kernel-test.mjs)