Fix Docker image build in goreleaser#51
Merged
Merged
Conversation
dockers_v2 uses buildx which doesn't support the simple binary copy pattern used in the Dockerfile. The classic dockers approach works correctly for this use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert from
dockers_v2todockersfor Docker image builds.dockers_v2usesdocker buildxwhich doesn't work with the simple binary-copy Dockerfile pattern. The classicdockersapproach correctly copies the built binary into the Docker context.dockersis deprecated but still fully supported. Whendockers_v2matures, we can migrate by switching to a multi-stage Dockerfile.