Add CORS middleware and a identification route to the fallback app#345
Open
julianstirling wants to merge 2 commits into
Open
Add CORS middleware and a identification route to the fallback app#345julianstirling wants to merge 2 commits into
julianstirling wants to merge 2 commits into
Conversation
It is hard query the fallback app over the API as it has no identification and throws a CORS error from browser code.
Barecheck - Code coverage reportTotal: 96.87%Your code coverage diff: 0.01% ▴ ✅ All code changes are covered |
rwb27
approved these changes
May 16, 2026
Collaborator
rwb27
left a comment
rwb27
left a comment
There was a problem hiding this comment.
This seems like a very uncontroversial good idea.
Given that we have tested release candidates for v0.2.0 I propose we release 0.2 from the same code as rc2 and then make 0.2.1 which includes this and the testing code for manual thing slots.
It's definitely a non breaking change, and it doesn't make major internal changes either. This is in line with what the docs currently say on releases.
For simplicity it might be worth holding off clicking merge until we've released 0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is hard query the fallback app over the API as it has no identification and throws a CORS error from browser code.
The CORS middleware is essential for getting OpenFlexure Connect to identify the callback. The extra identification route stops us having to search for known strings in the
openapi.jsondescription which seems fragile.It sort of feels like a feature that would should wait for v0.3.0. It is also really useful to have very soon.