fix: chat responses mode finish_reason#601
Merged
zijiren233 merged 2 commits intoJun 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the OpenAI Responses→Chat Completions adapter so finish_reason is correctly derived when using Responses API-backed models, including streaming support for response.incomplete and tool-call termination.
Changes:
- Add
responseToChatFinishReasonto map Responses APIincomplete_details.reasoninto Chat Completionsfinish_reason. - Update streaming conversion to emit a final chunk for
response.incompleteand to usetool_callswhen a tool call occurred. - Update non-stream conversion to produce choices for function-call output items and to handle responses that contain no message items.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/relay/adaptor/openai/chat.go | Maps Responses status/incomplete reasons to chat finish_reason, adds tool-call finish reason handling, and supports response.incomplete in streaming. |
| core/relay/adaptor/openai/chat_test.go | Adds test coverage for incomplete responses (reasoning-only, content filter) and tool-call-only scenarios in both non-stream and stream conversions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1269
to
+1276
| case "", relaymodel.InputItemTypeMessage: | ||
| choice := relaymodel.TextResponseChoice{ | ||
| Index: len(chatResp.Choices), | ||
| Message: relaymodel.Message{ | ||
| Role: outputItem.Role, | ||
| Content: "", | ||
| }, | ||
| } |
| }, | ||
| }, | ||
| }, | ||
| FinishReason: relaymodel.FinishReasonToolCalls, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.