feat!: switch metric types to Gauges#194
Open
breed808 wants to merge 1 commit into
Open
Conversation
Particularly since 61153ae, the exporter has been observing requests over a time period rather than request totals. That is, metric values are no longer increasing monotonically.
Contributor
|
Have you been able to test it ? |
|
Hi @haad sorry for the ping, |
Contributor
Author
|
Apologies, I haven't been able to test this yet, and may not for a few weeks yet. |
Contributor
|
Sure I'm happy to merge it once we get it tested by someone else this can also lead to breakage to other users dashboards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Particularly since 61153ae, the exporter has been observing requests over a time period rather than request totals. That is, metric values are no longer increasing monotonically.
Resolves #182
Type of Change
Testing
make pr-testsand all tests passCode Quality
Additional Notes
I should note this change is untested at the time of writing. I'm planning to run this in our environment sometime this week.