driver: usbsdmuxdriver: add GPIO get and set support#1891
Open
hamztouiz wants to merge 1 commit into
Open
Conversation
Add two new methods to USBSDMuxDriver: - get_gpio(gpio): reads the state of a GPIO pin (0 or 1), returns 'high' or 'low' - set_gpio(gpio, value): sets a GPIO pin to 'high'/'1' or 'low'/'0' Both methods use the 'gpio' subcommand of the usbsdmux CLI tool, which is available on hardware revisions that support open-drain GPIO outputs (e.g. USB-SD-Mux Fast). Signed-off-by: Hamza TOUIZRAT <hamzatouizrat@yahoo.com>
Emantor
reviewed
Jun 9, 2026
|
|
||
| @Driver.check_active | ||
| @step(title="sdmux_gpio_get", args=["gpio"]) | ||
| def get_gpio(self, gpio): |
Member
There was a problem hiding this comment.
Not using the DigitalOutputProtocol here means that we can't make use of the IOs in the client and discoverability is difficult (since the function is named differently)
But the DigitalOutputProtocol requires that the index of the GPIO is set beforehand.
@Bastian-Krause @jluebbe do you have a better idea here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new methods to
USBSDMuxDriver:get_gpio(gpio): reads the state of a GPIO pin (0 or 1), returns'high'or'low'set_gpio(gpio, value): sets a GPIO pin to'high'/'1'or'low'/'0'Both methods use the
gpiosubcommand of theusbsdmuxCLI tool,which is available on hardware revisions that support open-drain GPIO
outputs (e.g. USB-SD-Mux Fast).
Signed-off-by: Hamza TOUIZRAT hamzatouizrat@yahoo.com