Exporter error propagation#1886
Open
asher-pem-arm wants to merge 4 commits into
Open
Conversation
Replace boolean success/failure handling in the resource acquire and release helpers with CoordinatorError exceptions. This lets AcquirePlace and ReleasePlace return coordinator-side failure reasons to the client. This makes coordinator-side acquire/release failures actionable for users instead of only reporting a generic failed operation. Signed-off-by: Alex Tercete <alex.tercete@arm.com> Reviewed-by: Alex Tercete <alex.tercete@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
Signed-off-by: Alex Tercete <alex.tercete@arm.com> Reviewed-by: Alex Tercete <alex.tercete@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
Convert exporter acquire/release command timeouts into ExporterError failures. This returns a clear timeout reason to the client instead of relying on an empty TimeoutError message. Signed-off-by: Alex Tercete <alex.tercete@arm.com> Reviewed-by: Alex Tercete <alex.tercete@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
Avoid including the full resource representation in exporter acquire/release failure messages returned to the client. The exporter-provided reason is enough for users, while the full resource details can be noisy and may expose more information than needed. Signed-off-by: Alex Tercete <alex.tercete@arm.com> Reviewed-by: Alex Tercete <alex.tercete@arm.com> # gatekeeper Co-authored-by: Idan Saadon <idan.saadon@arm.com>
Emantor
requested changes
Jun 9, 2026
Member
There was a problem hiding this comment.
The second commit message will need an actual message instead of the title line and it may be beneficial to squash some commits.
I would like some test infrastructure for these new changes, but this requires rework of the coordinator/exporter/client testing in the testsuite first, which is out of scope for this PR.
Implementation wise this looks good and should improve our error reporting to the user.
Author
|
@Emantor happy to squash down to one commit if you think fits better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward acquire/release failure reasons through the coordinator to the client.
This makes coordinator and exporter failures visible to users instead of returning only a generic lock/acquire failure.
The MR is split into focused commits:
report coordinator-side acquire/release failures to the client
preserve exporter failure reasons
report exporter command timeouts
reduce exported resource details in user-facing errors
Without this, it is hard to tell whether a failure happened in the client, coordinator, exporter.