iteration / thread race condition fixes#33
Open
mweal-ed wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Note: I was probably a little pre-mature on submitting this. If it is used without "USE_THREAD", it will break the _async functions. |
Contributor
|
Thanks a lot @mweal-ed to have found the reason of this bug. My understanding is without |
Contributor
Author
|
You are correct, however I think there may be some hidden problems when using threads. |
Contributor
Author
|
I am not that experienced with git, so let me know what you want me to do to so we can proceed with these (and my other) fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 31 where there is an occasional race condition because the glib GMainContext g_gattlib_thread->loop_context is run in two threads (explicitly not allowed in glib documentation).
I have provided 2 different fixes controlled by defining USE_THREAD in gattlib_internal.h. The default operation does gattlib_iteration's as required. When USE_THREAD is defined a main loop is run in a separate thread (this is the way it is done in the existing code) for processing glib events. gattlib_iteration is still called but g_main_context_iteration is only called if gattlib_iteration was called from the same thread as the g_main_loop.
I do not like the USE_THREAD mode because:
I do not think it is necessary