Add Symplectic Integrator#32
Conversation
frostedoyster
left a comment
There was a problem hiding this comment.
The examples/ folder is probably a good idea, but it's too messy at the moment and it needs to be cleaned up. I see some dataset processing code and an ipynb that shouldn't be there.
The symplectic route should also be made available in ASE
| ) | ||
|
|
||
| # The barostat here needs a simpler splitting than for BZP, something as | ||
| # OAbBbBABbAbPO where Bp and Ap are the cell momentum and volume steps |
There was a problem hiding this comment.
There is no Bp or Ap in the sequence
There was a problem hiding this comment.
I have to look at the theory for that one. Nevertheless, the functional wrap_* code is just a generalization of what was available in ipi.py all along and the comment just got copied from here
Lines 249 to 250 in 44676ec
Or did I miss something when copying?
a602f45 to
55689ea
Compare
|
Thank you very much for your feedback! I tried addressing all your suggestions. Because the PR became very big, here is a short overview of some key design changes.
I hope this helps with reviewing this PR! |
|
closed in favor of #43 |
Add a fixed-point iteration based integrator.