Migrate to Vite+ (vp) unified toolchain - #68
Open
kwiersma wants to merge 7 commits into
Open
Conversation
Replaces the standalone Vite 7, Vitest, ESLint (9 plugins), and Prettier setup with vite-plus — VoidZero's unified toolchain that bundles Vite 8, Rolldown, Vitest, Oxlint (50–100x faster than ESLint), and Oxfmt under a single `vp` CLI. Changes: - Install vite-plus; add npm overrides for vite/vitest to vite-plus core packages - Remove eslint, prettier, and all associated plugins/configs (~15 packages) - Delete eslint.config.js and .prettierrc.cjs; inline lint/fmt config in vite.config.ts - Update all npm scripts to use vp (dev, build, test, lint, fmt, check) - Switch CI workflow to voidzero-dev/setup-vp@v1 action (handles node + install + cache) - Fix Rolldown assetFileNames null guard (assetInfo.name can be undefined in Rolldown) - Keep @vitejs/plugin-react at 5.x (v6 imports vite/internal not yet exported by vite-plus) - Update CLAUDE.md and README to reflect new toolchain Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CI was picking up a newer vite-plus via `latest`, which shipped an updated Oxfmt with different formatting opinions than the local install. Pin the exact version in package.json overrides and setup-vp so local and CI use identical tooling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
setup-vp's default run-install runs `npm install`, which rewrites package.json formatting before `vp check` runs, causing it to fail. Switching to run-install: false + explicit `npm ci` avoids the rewrite since npm ci only reads the lockfile and never modifies package.json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
setup-vp installs Node.js via `vp env use`, which runs a different npm version than local. That npm rewrites package.json with its own formatting before `vp check` runs. Since npm owns package.json's format, excluding it (and package-lock.json) from Oxfmt is the correct boundary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The fmt.ignore config key is not a valid Oxfmt option and was silently ignored. Oxfmt reads .prettierignore (and .gitignore) for file exclusions. Adding package.json and package-lock.json there is the correct mechanism. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
claude-code-action validates that the workflow file matches the default branch exactly as a security measure. Oxfmt had stripped a trailing newline, causing a content mismatch and 401 on every PR run. Restoring to match master and adding to .prettierignore so Oxfmt can never touch it again. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vptoolchain bundling Vite 8, Rolldown, Vitest, Oxlint, and Oxfmtvpequivalents; CI workflow switches tovoidzero-dev/setup-vp@v1What changed
vp lintvp fmtactions/setup-node+npm civoidzero-dev/setup-vp@v1eslint.config.js+.prettierrc.cjsvite.config.ts(lint/fmtsections)Dropped rules (no Oxlint equivalents)
import-x/order— alphabetical import orderingimport-x/no-cycle— circular dependency detectionReviewer notes
assetFileNamesinvite.config.tsnow guards againstassetInfo.namebeingundefined— Rolldown passesundefinedfor internally generated CSS assets, unlike Rollup. Build output structure (static/js/,static/css/) is unchanged.@vitejs/plugin-reactstays at 5.x: v6 importsvite/internal, a subpath not yet exported by@voidzero-dev/vite-plus-core. Will upgrade once Vite+ exposes it.vite-plusis at v0.1.16 (alpha). Pinned tolatestfor now; consider pinning to a specific version before a production release.vp checkis clean,vp buildproduces correct output.🤖 Generated with Claude Code