Skip to content

fix: prevent localStorage quota overflow in plugin safety cache #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OnlookerRs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent localStorage quota overflow in plugin safety cache #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions src/ts/plugins/pluginSafety.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,17 @@ export async function checkCodeSafety(code: string): Promise<CheckResult> {

const hashedCode = await hasher(new TextEncoder().encode(code));
const cacheKey = `safety-${hashedCode}`;
const cachedResult = localStorage.getItem(cacheKey);
if (cachedResult) {
const got = JSON.parse(cachedResult) as CheckResult;
if (got.checkerVersion === checkerVersion) {
return got;
try {
const cachedResult = localStorage.getItem(cacheKey);
if (cachedResult) {
const got = JSON.parse(cachedResult) as CheckResult;
if (got.checkerVersion === checkerVersion) {
return got;
}
localStorage.removeItem(cacheKey);
}
} catch {
try { localStorage.removeItem(cacheKey); } catch {}
}

try {
Expand Down Expand Up @@ -150,8 +155,29 @@ export async function checkCodeSafety(code: string): Promise<CheckResult> {
userAlertKey: 'errorInVerification'
})

localStorage.setItem(cacheKey, JSON.stringify({ isSafe: errors.length === 0, errors, checkerVersion, modifiedCode:code }));
return { isSafe: errors.length === 0, errors, checkerVersion, modifiedCode: code};
const result: CheckResult = { isSafe: errors.length === 0, errors, checkerVersion, modifiedCode: code };
try {
localStorage.setItem(cacheKey, JSON.stringify(result));
} catch {
purgeSafetyCache(cacheKey);
try { localStorage.setItem(cacheKey, JSON.stringify(result)); } catch {}
}
return result;
}

function purgeSafetyCache(keepKey?: string) {
try {
const toRemove: string[] = [];
for (let i = 0; i < localStorage.length; i++) {
const key = localStorage.key(i);
if (key?.startsWith('safety-') && key !== keepKey) {
toRemove.push(key);
}
}
for (const key of toRemove) {
localStorage.removeItem(key);
}
} catch {}
}

function validateNode(node: any, type: DangerousNodeType, name: string | undefined, errors: PluginSafetyErrors[]) {
Expand Down
Loading