Skip to content

Enable use with cryptography 39+ using new RSA validation skip parameter#4

Open
colindean wants to merge 1 commit into
kvdveer:masterfrom
colindean:cryptography-39
Open

Enable use with cryptography 39+ using new RSA validation skip parameter#4
colindean wants to merge 1 commit into
kvdveer:masterfrom
colindean:cryptography-39

Conversation

@colindean

Copy link
Copy Markdown

…and cleans up the code with some logging statements.

Fixes #3

…and cleans up the code with some logging statements.

@thenger thenger left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that.
I might add my point of view:
I think adding "..." at end of logs is not a good thing

Even if it will probably never work I think you can add an option to set unsafe_skip_rsa_key_validation=False

This new change (the fact that we explicitly tell not to verify the key) should be explained in the README

thank you for removing the trailing whitespace <3

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails with Invalid private key

2 participants