chore(release): bump version to v0.1.1 - #105
Conversation
|
🔍 OpenCodeReview found 3 issue(s) in this PR.
|
| validate-version: | ||
| name: Validate release version | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
[security · medium]
This new job does not declare token permissions, so its GITHUB_TOKEN access depends on the repository's potentially broader default. The validation only needs to check out the repository; explicitly grant read-only contents access at the job level.
Suggestion:
| validate-version: | |
| name: Validate release version | |
| runs-on: ubuntu-24.04 | |
| validate-version: | |
| name: Validate release version | |
| runs-on: ubuntu-24.04 | |
| permissions: | |
| contents: read |
There was a problem hiding this comment.
Adding explicit read-only permissions to the validate-version job would be a reasonable least-privilege improvement:
permissions:
contents: read
I don’t consider this blocking, though.
| name: Validate release version | ||
| runs-on: ubuntu-24.04 | ||
| steps: |
There was a problem hiding this comment.
[other · low]
The new validation job has no timeout, so a stalled toolchain installation or cargo metadata invocation can consume a runner indefinitely and block all dependent release jobs. Add an appropriate timeout-minutes value.
Suggestion:
| name: Validate release version | |
| runs-on: ubuntu-24.04 | |
| steps: | |
| name: Validate release version | |
| runs-on: ubuntu-24.04 | |
| timeout-minutes: 10 | |
| steps: |
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
[security · high]
dtolnay/rust-toolchain is a third-party action and stable is a mutable ref. If that ref is moved or compromised, release-tag runs can execute changed code. Pin this action to a reviewed full commit SHA (a trailing comment can document the corresponding version/ref).
|
Can you merge #87 before releasing v0.1.1? |
| validate-version: | ||
| name: Validate release version | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Adding explicit read-only permissions to the validate-version job would be a reasonable least-privilege improvement:
permissions:
contents: read
I don’t consider this blocking, though.
Summary
workspace.packageand bump it to 0.1.1aenvCLI inherit the shared versionVerification
cargo fmt --all --checkcargo check -p agentenv -p aenv --lockedcargo run --quiet -p aenv -- --versionoutputsaenv 0.1.1v0.1.1After this PR merges,
v0.1.1can be tagged on the merge commit to start the existing release workflow.