Support configurable storage driver, register S3/Google connectors, remove debug prints, and add release readiness review#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fe7caf93b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -57,7 +57,6 @@ func (m *SubscriptionManager) registerDefaultPlugins() { | |||
| _ = m.pluginRegistry.Register(model.DatasetTypeJSON, jsonPlugin.NewJSONDataPlugin()) | |||
| _ = m.pluginRegistry.Register(model.DatasetTypeCSV, csvPlugin.NewCSVDataPlugin()) | |||
| _ = m.pluginRegistry.Register(model.DatasetTypeSQL, sqlitePlugin.NewSQLiteDataPlugin()) | |||
There was a problem hiding this comment.
Restore Postgres-aware SQL plugin registration
By removing the second DatasetTypeSQL registration, SQL datasets now always use SQLiteDataPlugin even when storage.driver=postgres. That plugin infers booleans as INTEGER (internal/plugins/sqlite/plugin.go), but Postgres insert generation emits TRUE/FALSE literals (internal/db/postgres.go), which causes type-mismatch failures when ingesting SQL datasets containing boolean fields on Postgres-backed runtimes. This regression comes directly from dropping the Postgres plugin registration in defaults.
Useful? React with 👍 / 👎.
Motivation
RELEASE_READINESS_REVIEW.mdto guide next steps for public release.Description
newDataStoreClient(cfg configs.Config)and updatednewRuntimeto use it, routingstorage.drivertodatastore.NewSQLiteDataStoreClientordatastore.NewPostgresDataStoreClientand returning a clear error for unsupported drivers.TestNew_UnsupportedDriverandTestNew_PostgresWithoutDSNtopkg/runtime/runtime_test.goto validate driver selection and DSN requirements.SubscriptionManagerand updated the registration test expectations ininternal/subscription_manager/main_test.go.PingonS3Connectorto validate connectivity and ensureConnect+Closebehavior can be exercised.printDirRecursivehelper from the Git connector to avoid exposing filesystem paths and contents.RELEASE_READINESS_REVIEW.mddocumenting high-priority issues and release-focused recommendations.Testing
go test ./..., which executed the subscription manager registration tests and runtime tests includingTestNew_UnsupportedDriverandTestNew_PostgresWithoutDSN.Codex Task