added new test case and imporved type safety#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c13b4c4669
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| opts, err := entities.DecodeDatasetOptions[entities.CSVDatasetOptions]( | ||
| params.DatasetContext.DatasetOptions, | ||
| ) |
There was a problem hiding this comment.
Switching to DecodeDatasetOptions here drops the key-normalization behavior that ConvertMapToCSVPluginOptions previously provided, so common YAML-style keys like has_headers, skip_lines, or dedupe_key are no longer mapped into CSVDatasetOptions and are silently ignored. In practice this can make header rows get ingested as data (or skip settings not apply), producing incorrect CSV results for existing plans that still use those keys.
Useful? React with 👍 / 👎.
1 participant
No description provided.