Refactor datastore internals and tighten query option safety#3
Merged
squeakycheese75 merged 2 commits intoApr 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
%wwrapping for better error propagation.Description
internal/datastoreinto focused files:client.go,query_options.go,postgres_client.go,sqlite_client.go,sqlite_storage.go, plus existingfactory.go,sqlite_storage_local.go, andsqlite_storage_s3.go.SqliteDataStoreClienttoSQLiteDataStoreClientand kept constructor APIsNewSQLiteDataStoreClient/NewSQLiteDataStoreClientWithStorageintact.FindandQueryin both SQLite and Postgres clients to return[]map[string]interface{}{}withnilerror when no rows are found, and improved error messages using%wwrapping where appropriate.ApplyQueryOptionsWithSafetyso it no longer infersAllowedColsfromFilters/OrderBywhenAllowedColsis empty and now validates/returns an error for invalid filter or order columns.%wwrapping and corrected a Postgres unmarshal error label.internal/datastore/client_query_test.goto cover empty-result handling and invalid query options.Testing
internal/datastore/client_query_test.gocovering empty results forFind/Queryand invalidQueryOptions, and they passed when running the package tests.go test ./internal/datastoreand it completed successfully.go test ./...and the full test suite completed successfully (no failures reported).Codex Task