Skip to content

Time domain stretching#104

Merged
kunitoki merged 2 commits into
mainfrom
dev/time_stretch_time
May 25, 2026
Merged

Time domain stretching#104
kunitoki merged 2 commits into
mainfrom
dev/time_stretch_time

Conversation

@kunitoki
Copy link
Copy Markdown
Owner

This pull request adds support and comprehensive tests for the new timeDomain backend in the TimeStretchProcessor, making it available as a selectable and testable backend for time-stretching operations. The changes also improve test coverage and simplify build configuration for backend-specific tests.

TimeStretchProcessor Backend Support:

  • Added the timeDomain backend option to the TimeStretchProcessor::Backend enum, allowing explicit selection of the built-in time-domain backend.
  • Updated backend availability and discovery logic to include the timeDomain backend in isBackendAvailable and getAvailableBackends.

Testing Enhancements:

  • Added multiple tests for preparing, setting, and processing with the timeDomain backend, ensuring it can be selected, initialized, and used for processing audio. [1] [2] [3]
  • Improved conditional compilation for Bungee backend tests, wrapping them with #if YUP_ENABLE_BUNGEE to avoid unnecessary test exclusion and to clarify backend-specific coverage. [1] [2] [3]

Build Configuration:

  • Removed unnecessary preprocessor conditionals around the inclusion of yup_TimeStretchProcessor.cpp in the test suite, ensuring the file is always included.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 88.94118% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.86%. Comparing base (c64d1c2) to head (f908896).

Files with missing lines Patch % Lines
..._dsp/stretching/yup_TimeStretchTimeDomainBackend.h 90.73% 29 Missing ⚠️
.../yup_dsp/stretching/yup_TimeStretchBungeeBackend.h 82.85% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   74.76%   74.86%   +0.09%     
==========================================
  Files         587      590       +3     
  Lines       58891    59209     +318     
==========================================
+ Hits        44031    44326     +295     
- Misses      14860    14883      +23     
Files with missing lines Coverage Δ
...es/yup_dsp/stretching/yup_TimeStretchProcessor.cpp 94.16% <100.00%> (+5.50%) ⬆️
...ules/yup_dsp/stretching/yup_TimeStretchProcessor.h 83.33% <ø> (ø)
...up_dsp/stretching/yup_TimeStretchProcessorEngine.h 100.00% <100.00%> (ø)
modules/yup_dsp/windowing/yup_WindowFunctions.h 84.90% <ø> (ø)
.../yup_dsp/stretching/yup_TimeStretchBungeeBackend.h 82.85% <82.85%> (ø)
..._dsp/stretching/yup_TimeStretchTimeDomainBackend.h 90.73% <90.73%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64d1c2...f908896. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit b7eee0c into main May 25, 2026
46 of 47 checks passed
@kunitoki kunitoki deleted the dev/time_stretch_time branch May 25, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant