Fix check compat should early exit#32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new minor version (0.21.0) and focuses on improving the handling of breaking changes in the CLI, ensuring output files are not written when breaking changes are detected during compatibility checks. It also updates the test suite to validate this behavior and makes minor documentation updates.
CLI breaking change handling improvements
src/tsujikiri/cli.py) so that if breaking changes are detected with--check-compat, the process exits with status 1 before generating any output files, ensuring no output is written in this scenario. [1] [2]Test suite enhancements
test_breaking_change_does_not_write_output_file) to verify that output files are not written when breaking changes are detected, and refactored some existing tests for clarity and coverage. [1] [2]Version update
0.21.0insrc/tsujikiri/__init__.py.Documentation updates
README.mdto use a new query parameter. [1] [2]