fix(agents): recover Copilot and OpenCode JSON output#149
Merged
kunchenguid merged 1 commit intoMay 13, 2026
Merged
Conversation
bb6a86e to
910721d
Compare
Owner
|
Thanks - scoped exactly as discussed in #147, and the helpers track the rovodev shape closely. The fork-blocked no-mistakes check is understood; merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.parseto the sharedparseAgentJson(...)recovery pathfinal_answerfallback parsing to the same shared recovery pathScope
This intentionally only fixes Copilot and OpenCode, matching the owner suggestion on #147. I did not move
parseAgentJson(...)outside adapter implementations in this PR. Long-term, that could make sense as a shared post-adapter normalization layer, but it would be a broader abstraction change than this fix needs.Local validation
npx vitest run src/core/agents/copilot.test.ts src/core/agents/opencode.test.tsparseAgentJson(...)-based local build with GLM 5.1 and deep-v4-flash, and both worked as expected.Addresses #147
Pipeline
Updates from git push no-mistakes
Local no-mistakes gate ran review, test, document, and lint for this branch. The final upstream push step was blocked by fork permissions, so the branch remains published from Arcadia822/gnhf.