build: migrate repository tooling to pnpm workspace#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
packages/axi-sdk-jswith a sharedpnpm-lock.yamlandpnpm-workspace.yaml.Risk Assessment
✅ Low: The remaining changes are limited to package-manager migration, workspace lockfile consolidation, and CI command/path-filter updates, with the prior material CI coverage gap addressed and no additional substantiated merge-blocking risks found.
Testing
pnpm install --frozen-lockfilepnpm --dir packages/axi-sdk-js testpnpm --dir bench-browser testpnpm --dir bench-github testPipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
Round 1 - passed ✅
✅ **Rebase** - passed
Round 1 - passed ✅
🔧 **Review** - 1 issue found → auto-fixed
Round 1 - found 1 warning
.github/workflows/axi-sdk-js-ci.yml:28- This job now installs from the rootpnpm-lock.yaml, but the workflow path filters still only includepackages/axi-sdk-js/**and the workflow file. A PR that only updates the shared lockfile or root pnpm workspace config foraxi-sdk-jsdependencies will skip this CI workflow, unlike the previous per-packagepackage-lock.jsonsetup. Addpnpm-lock.yaml,pnpm-workspace.yaml, and the rootpackage.jsonto the relevant path filters.Round 2 (auto-fix) - passed ✅
✅ **Test** - passed
Round 1 - passed ✅
pnpm install --frozen-lockfilepnpm --dir packages/axi-sdk-js testpnpm --dir bench-browser testpnpm --dir bench-github test🔧 **Document** - 4 issues found → auto-fixed
Round 1 - found 4 warnings
README.md:100- The Browser Benchmark development instructions still use npm commands even though this change removes package-lock.json files, adds pnpm-workspace.yaml, and declares pnpm@11.1.1 as the repository package manager. Update this section to install and run the browser benchmark through pnpm/workspace-aware commands.README.md:125- The GitHub Benchmark development instructions still use npm commands even though the repo now uses a pnpm workspace and the bench-github package-lock.json was removed. Update this section to use pnpm for installation and benchmark/report commands.AGENTS.md:20- The agent-facing development command reference still tells agents to run npm install/npm run/npm test in bench-github and bench-browser. Because the change migrates dependency management to a root pnpm workspace, these instructions are stale and should be updated to pnpm commands.packages/axi-sdk-js/README.md:83- The axi-sdk-js development section still says to run npm ci inside packages/axi-sdk-js, but the package-specific package-lock.json was removed and CI now installs from the root pnpm workspace. Update the development instructions to use pnpm install from the workspace and pnpm --dir packages/axi-sdk-js for test/build commands.Round 2 (auto-fix) - passed ✅
✅ **Lint** - passed
Round 1 - passed ✅
✅ **Push** - passed
Round 1 - passed ✅