Skip to content

hotfix: use pipeline without tx #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zipzap11 merged 2 commits into from
Aug 28, 2025
Merged

hotfix: use pipeline without tx #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccde3c
hotfix: use pipeline without tx
Aug 27, 2025
74be6d8
bump: update changelog
Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# cacher-v2

<a name="v2.8.2"></a>
## [v2.8.2] - 2025-08-27
### Fixes
- use pipeline without tx


<a name="v2.8.1"></a>
## [v2.8.1] - 2025-08-21
### Other Improvements
- downgrade go-redis version to v9.11.0
- downgrade go-redis version to v9.11.0 ([#61](https://github.com/kumparan/cacher/issues/61))


<a name="v2.8.0"></a>
Expand Down Expand Up @@ -618,7 +624,8 @@
<a name="v1.0.0"></a>
## v1.0.0 - 2019-04-01

[Unreleased]: https://github.com/kumparan/cacher/compare/v2.8.1...HEAD
[Unreleased]: https://github.com/kumparan/cacher/compare/v2.8.2...HEAD
[v2.8.2]: https://github.com/kumparan/cacher/compare/v2.8.1...v2.8.2
[v2.8.1]: https://github.com/kumparan/cacher/compare/v2.8.0...v2.8.1
[v2.8.0]: https://github.com/kumparan/cacher/compare/v1.20.0...v2.8.0
[v1.20.0]: https://github.com/kumparan/cacher/compare/v1.19.0...v1.20.0
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
cacher@v2.8.1
cacher@v2.8.2
5 changes: 4 additions & 1 deletion keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,10 @@ func (k *keeper) StoreMultiHashMembers(ctx context.Context, mapIdentifiersToMemb
return nil
}

pipeline := k.connPool.TxPipeline()
// using Pipeline instead of TxPipeline because TxPipeline force operation on multiple keys
// to be done in 1 cluster slot, so it doesn't support multiple slot operation
// reference: https://stackoverflow.com/a/38042895
pipeline := k.connPool.Pipeline()

@aslamhadi aslamhadi Aug 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tambahin comment kenapa diganti gini jung

for i, items := range mapIdentifiersToMembers {
for _, v := range items {
err = pipeline.HSet(ctx, i, v.GetKey(), v.GetValue()).Err()
Expand Down