Skip to content

Address review feedback: de-duplicate file-scan proto conversions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriangb wants to merge 4 commits into
base: issue-23497-datasource-proto-hooks
Choose a base branch
from
Open

Address review feedback: de-duplicate file-scan proto conversions #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1213e29
Move PartitionedFile/FileGroup proto conversions into datafusion-data…
adriangb Jul 30, 2026
d38ebef
Rename FileScanConfig proto helpers to try_to_proto / try_from_proto
adriangb Jul 30, 2026
bf93028
Deprecate datafusion-proto's parse_table_schema_from_proto wrapper
adriangb Jul 30, 2026
262b402
Put Partitioning / PhysicalSortExpr proto conversion on the types
adriangb Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/datasource/src/file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ pub trait FileSource: Any + Send + Sync {
/// `base` is the shared [`FileScanConfig`] this source is wrapped in; the
/// format-agnostic parts (file groups, schema, statistics, ordering,
/// projection, …) are encoded via
/// [`FileScanConfig::to_proto_conf`](crate::file_scan_config::FileScanConfig::to_proto_conf),
/// [`FileScanConfig::try_to_proto`](crate::file_scan_config::FileScanConfig::try_to_proto),
/// and the concrete source appends its format-specific fields (e.g. CSV
/// delimiter/quote) around it.
///
Expand Down
2 changes: 1 addition & 1 deletion datafusion/datasource/src/file_scan_config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
pub(crate) mod sort_pushdown;

/// Shared `FileScanConfig` <-> proto conversion, gated on the `proto` feature.
/// Attaches inherent `to_proto_conf` / `from_proto_conf` / `parse_table_schema_from_proto`
/// Attaches inherent `try_to_proto` / `try_from_proto` / `parse_table_schema_from_proto`
/// helpers to [`FileScanConfig`] used by every file source's `try_to_proto` hook.
#[cfg(feature = "proto")]
pub(crate) mod proto;
Expand Down
Loading
Loading