Skip to content

Revise IPMI guide with new credentials and info#10

Open
halfcrazy wants to merge 1 commit into
kubevirtbmc:mainfrom
halfcrazy:patch-1
Open

Revise IPMI guide with new credentials and info#10
halfcrazy wants to merge 1 commit into
kubevirtbmc:mainfrom
halfcrazy:patch-1

Conversation

@halfcrazy

Copy link
Copy Markdown

Updated IPMI guide to reflect new default credentials and removed outdated authentication limitation details.

fix kubevirtbmc/kubevirtbmc#195

Comment thread docs/ipmi-guide.md Outdated
Comment thread docs/ipmi-guide.md Outdated
@anishbista60

Copy link
Copy Markdown
Member

Last one nit, could you please add the line saying something "credential will be taken from kubernetes secret"

@anishbista60

anishbista60 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Last one nit, could you please add the line saying something "credential will be taken from kubernetes secret"

I mean just this part, latest commit have a lots changes which I feel not required at all. Docs will look messy.

I am sorry for being picky on this part but I would recommend to revert back to the last branch id and add note section for above

@halfcrazy

Copy link
Copy Markdown
Author

Last one nit, could you please add the line saying something "credential will be taken from kubernetes secret"

I mean just this part, latest commit have a lots changes which I feel not required at all. Docs will look messy.

I am sorry for being picky on this part but I would recommend to revert back to the last branch id and add note section for above

I think variable clarification can be handled together with IPMI modifications, and the extra introduction about Redfish SystemID 1 can be removed.

@anishbista60

anishbista60 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Last one nit, could you please add the line saying something "credential will be taken from kubernetes secret"

I mean just this part, latest commit have a lots changes which I feel not required at all. Docs will look messy.
I am sorry for being picky on this part but I would recommend to revert back to the last branch id and add note section for above

I think variable clarification can be handled together with IPMI modifications, and the extra introduction about Redfish SystemID 1 can be removed.

totally understand you part.

It's simple like me as the new person who are trying to test something with kubevirtbmc.

Following the docs, I won't replace the value for very command. It will be every hectic for me.

for example: Need to replace username , password, vm-name, namespace.

ipmitool -I lan \
    -U <username-from-auth-secret> \
    -P <password-from-auth-secret> \
    -H <vm-name>-virtbmc.<namespace>.svc.cluster.local \
    power on

secondly, I feel people will know that <vm-name> meaning Virtual machine and similar to other variable as well.

Note: I really appreciate your effort, but I feel these many changes will make docs messy.

@halfcrazy

Copy link
Copy Markdown
Author

Last one nit, could you please add the line saying something "credential will be taken from kubernetes secret"

I mean just this part, latest commit have a lots changes which I feel not required at all. Docs will look messy.

I am sorry for being picky on this part but I would recommend to revert back to the last branch id and add note section for above

I think variable clarification can be handled together with IPMI modifications, and the extra introduction about Redfish SystemID 1 can be removed.

totally understand you part.

It's simple like me as the new person who are trying to test something with kubevirtbmc.

Following the docs, I won't replace the value for very command. It will be every hectic for me.

for example: Need to replace username , password, vm-name, namespace.

ipmitool -I lan \

    -U <username-from-auth-secret> \

    -P <password-from-auth-secret> \

    -H <vm-name>-virtbmc.<namespace>.svc.cluster.local \

    power on

secondly, I feel people will know that <vm-name> meaning Virtual machine and similar to other variable as well.

Note: I really appreciate your effort, but I feel these many changes will make docs messy.

Okay, I'll make the revisions tomorrow.

Updated IPMI guide to reflect new default credentials and removed outdated authentication limitation details.

fix kubevirtbmc/kubevirtbmc#195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IPMI doesn't check authentication

2 participants