Skip to content

compute: add PCI topology and hotplug port reservation docs#980

Open
mhenriks wants to merge 1 commit into
kubevirt:mainfrom
mhenriks:pci-guide
Open

compute: add PCI topology and hotplug port reservation docs#980
mhenriks wants to merge 1 commit into
kubevirt:mainfrom
mhenriks:pci-guide

Conversation

@mhenriks

Copy link
Copy Markdown
Member

Document the PCI topology versions (v1, v2, v3), how hotplug port reservation works, and upgrade behavior. Includes troubleshooting guidance for Windows VMs with offline disks after upgrading from KubeVirt 1.6/1.7 to versions with the v3 fix (1.6.4, 1.7.2, 1.8+).

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

compute: add PCI topology and hotplug port reservation docs

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 18, 2026
@mhenriks

Copy link
Copy Markdown
Member Author

cc @jean-edouard @vladikr @xpivarc

@kubevirt-bot

Copy link
Copy Markdown
Contributor

There has been no activity on this PR for 45 days.
To protect limited CI resources, it has been automatically labelled 'stale'.
This PR will automatically rot after an additional 14 days of inactivity, and will be closed shortly after that.

What you can do:

  • If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
  • You can mark the PR as fresh and remove the label with the following command: /remove-lifecycle stale
  • If this PR is safe to close now, please help the project by closing it with: /close
  • If you need attention on this PR from a reviewer, you can raise it on the agenda of the relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2026
@mhenriks

mhenriks commented May 7, 2026

Copy link
Copy Markdown
Member Author

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2026
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2026
@kubevirt-bot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jean-edouard jean-edouard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@dhiller dhiller removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2026
@dhiller

dhiller commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Removing needs-rebase label — the PR was force-pushed after the label was applied, which likely coincided with a GitHub glitch.

🤖 Assisted by Claude

@aburdenthehand aburdenthehand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mhenriks
For the most part this is clean and clear but I think the Topology:KubeVirt versioning could be made clearer, along with a lot of the headings.

Comment thread docs/compute/pci_topology.md Outdated
Comment thread docs/compute/pci_topology.md
Comment thread docs/compute/pci_topology.md Outdated
Comment thread docs/compute/pci_topology.md Outdated
Comment thread docs/compute/pci_topology.md Outdated
Same hotplug capacity as v2, same device addresses as v1.

## Upgrade Behavior

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously said "Understanding these is important when upgrading, as VMs created under different versions may behave differently."
So let's add an introduction here that more or less repeats that and links back to the Topology–KubeVirt version table. We can also then simplify these headings so they don't need the KubeVirt versions in them. (ie ### Upgrading from v1 to v3)

Comment thread docs/compute/pci_topology.md Outdated
Document the PCI topology versions (v1, v2, v3), how hotplug port
reservation works, and upgrade behavior. Includes troubleshooting
guidance for Windows VMs with offline disks after upgrading from
KubeVirt 1.6/1.7 to versions with the v3 fix (1.6.4, 1.7.2, 1.8+).

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants