compute: add PCI topology and hotplug port reservation docs#980
compute: add PCI topology and hotplug port reservation docs#980mhenriks wants to merge 1 commit into
Conversation
|
There has been no activity on this PR for 45 days. What you can do:
/lifecycle stale |
|
/remove-lifecycle stale |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Removing 🤖 Assisted by Claude |
aburdenthehand
left a comment
There was a problem hiding this comment.
Nice work @mhenriks
For the most part this is clean and clear but I think the Topology:KubeVirt versioning could be made clearer, along with a lot of the headings.
| Same hotplug capacity as v2, same device addresses as v1. | ||
|
|
||
| ## Upgrade Behavior | ||
|
|
There was a problem hiding this comment.
We previously said "Understanding these is important when upgrading, as VMs created under different versions may behave differently."
So let's add an introduction here that more or less repeats that and links back to the Topology–KubeVirt version table. We can also then simplify these headings so they don't need the KubeVirt versions in them. (ie ### Upgrading from v1 to v3)
Document the PCI topology versions (v1, v2, v3), how hotplug port reservation works, and upgrade behavior. Includes troubleshooting guidance for Windows VMs with offline disks after upgrading from KubeVirt 1.6/1.7 to versions with the v3 fix (1.6.4, 1.7.2, 1.8+). Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
Document the PCI topology versions (v1, v2, v3), how hotplug port reservation works, and upgrade behavior. Includes troubleshooting guidance for Windows VMs with offline disks after upgrading from KubeVirt 1.6/1.7 to versions with the v3 fix (1.6.4, 1.7.2, 1.8+).
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: