Skip to content

Fix version string generation#62

Open
Dany9966 wants to merge 1 commit into
kubevirt:masterfrom
Dany9966:generated-version-fix
Open

Fix version string generation#62
Dany9966 wants to merge 1 commit into
kubevirt:masterfrom
Dany9966:generated-version-fix

Conversation

@Dany9966

@Dany9966 Dany9966 commented Jun 4, 2026

Copy link
Copy Markdown

What this PR does / why we need it:
This patch sets a post-generation script that reformats the provided version string into a format the PEP440 accepts, so that pip installs are not completely broken on newer versions of setuptools.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56 #60

Special notes for your reviewer:
Needs python3 installed on the machine that executes the client generation.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/M labels Jun 4, 2026
@Dany9966 Dany9966 marked this pull request as draft June 4, 2026 14:38
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2026
This patch sets a post-generation script that reformats the provided
version string into a format the PEP440 accepts, so that pip installs
are not completely broken on newer versions of setuptools.

NOTE: Needs python3 installed on the machine that executes the
generation.

Signed-off-by: Daniel Vincze <dvincze@cloudbasesolutions.com>
@Dany9966 Dany9966 force-pushed the generated-version-fix branch from fd9ae47 to 5a1eaf4 Compare June 4, 2026 14:39
@kubevirt-bot kubevirt-bot removed the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jun 4, 2026
@Dany9966 Dany9966 marked this pull request as ready for review June 4, 2026 14:39
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 4, 2026
@kubevirt-bot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kubevirt-py package version does not conform to PEP 440

2 participants