Fix version string generation#62
Open
Dany9966 wants to merge 1 commit into
Open
Conversation
This patch sets a post-generation script that reformats the provided version string into a format the PEP440 accepts, so that pip installs are not completely broken on newer versions of setuptools. NOTE: Needs python3 installed on the machine that executes the generation. Signed-off-by: Daniel Vincze <dvincze@cloudbasesolutions.com>
fd9ae47 to
5a1eaf4
Compare
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch sets a post-generation script that reformats the provided version string into a format the PEP440 accepts, so that pip installs are not completely broken on newer versions of setuptools.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #56 #60
Special notes for your reviewer:
Needs
python3installed on the machine that executes the client generation.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: