Security: pin infra reusable workflows to immutable SHA and add fork guards#5944
Security: pin infra reusable workflows to immutable SHA and add fork guards#5944Copilot wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
❌ Deploy Preview for kubestellar-docs failed. Why did it fail? →
|
|
Hi @Copilot. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Two security issues in GitHub Actions workflows: mutable
@mainrefs on reusable workflow calls (supply chain risk) and unguardedpull_request_targettriggers (fork-based privilege escalation risk).📝 Summary of Changes
kubestellar/infrareusable workflow references from@mainto@a160acca0bdce1ac6c649e006d680d5f6d53024eif:fork guards to allpull_request_targetjobs to block execution from fork PRsChanges Made
kubestellar/infraworkflow refs to immutable SHA in 10 workflow files:add-help-wanted.yml,assignment-helper.yml,copilot-dco.yml,feedback.yml,label-helper.yml,pr-verifier.yml,scorecard.yml,stale.yml,greetings.yml,copilot-automation.ymlpr-verifier.yml:greetings.yml(also handlesissuestrigger):copilot-automation.yml(also handlesworkflow_dispatchtrigger):Checklist
Please ensure the following before submitting your PR:
Security Considerations
If this PR modifies any security-sensitive files, confirm:
Leave unchecked if not applicable. See CONTRIBUTING.md for details.
Screenshots or Logs (if applicable)
👀 Reviewer Notes
The SHA
a160acca0bdce1ac6c649e006d680d5f6d53024eis the current HEAD ofkubestellar/infraat time of this fix. Should be updated wheneverkubestellar/infrachanges are intentionally adopted. Disabled workflow files (*.disabled) andai-fix.ymlwere out of scope per the issue.Original prompt